c# getting crazy with a simple insert into....

Hi all :)
Here is my problem:

myCommand =new SqlCommand("insert into myTable values("@field1")", myConnection);
myParam =new SqlParameter();
myParam.ParameterName = "@field1";
myParam.Value = myTextBox1.Text;
myCommand.ExecuteNonQuery();

Whatever i write in myTextBox1.Text, in database i obtain ever a "null".
If i modify my insert like:"insert into myTable values('" + myTextBox1.Text + "')";
it work...but we know that it isnt a safe way to solve proble, thinking at sql iniection for example... So...a gentleman that show me where i wrong?
Thx in advance.

[888 byte] By [maxithron] at [2007-12-17]

«« Excel Active Cell change event?
»» Different Source Control options when creating a project

# 1

Have you added myParam to myCommand? And I don't think you need " in insert.. I'm not sure, but you should be able to write it like:

"insert into myTable values(@field1)"

KonstantinGonikman at 2007-9-8 >

top of Msdn Tech,Windows Forms,Windows Forms Data Controls and Databinding...

# 2

Konstantin Gonikman wrote:
Have you added myParam to myCommand? And I don't think you need " in insert.. I'm not sure, but you should be able to write it like:
"insert into myTable values(@field1)"

Yes, on the upper code i've only made a copy/paste error :)
myCommand.Parameter.Add(myParam);
But still have null value :(

maxithron at 2007-9-8 >

# 3

So, tried it without "?

KonstantinGonikman at 2007-9-8 >

# 4

Konstantin Gonikman wrote:
So, tried it without "?

here is current code:

cm = new SqlCommand("insert into myTable (field1) values (@field1)", cn);
SqlParameter p = new SqlParameter();
p.ParameterName = "@field1";
p.Value = txtField.Text;
cm.Parameters.Add(p);
cm.ExecuteNonQuery();

With this...still have "null" :(

maxithron at 2007-9-8 >

# 5

Hmmm.... I just tried the same and it works...

try 
 {
 SqlCommand cm = new SqlCommand("insert into Categories (CategoryName) values (@f)", sqlConnection1);
 
 SqlParameter p = new SqlParameter("@f", SqlDbType.NVarChar);
 p.Value = "my text";
 cm.Parameters.Add(p);
 
 sqlConnection1.Open();
 
 cm.ExecuteNonQuery();
 
 sqlConnection1.Close();
 }
 catch(Exception ex) 
 {
 Console.WriteLine(ex);
 }

KonstantinGonikman at 2007-9-8 >

# 6

There is only one difference:
Your's param Value is a string.
My Param's Value will be a textBox.text.
If i try with a string, works for me too.
Thx a lot for support :)

maxithron at 2007-9-8 >

# 7

Yes, but textBox.Text is a string as well

KonstantinGonikman at 2007-9-8 >

# 8