FXCOP

Update: Updated to include the OpCode.Jmp instruction.

Sounds like you could be using my AvoidComplicatedMethods rule and you have not included the RuleHelper class.

Anyway here is its implementation:

public static bool IsMethodCall(Instruction instruction) { if (instruction == null) throw new ArgumentNullException("instruction"); switch (instruction.OpCode) { case OpCode.Callvirt: case OpCode.Call: case OpCode.Calli: case OpCode.Jmp: return true; } return false; }

DavidM.Kean at 2007-9-9 >

Michael,

Didn't know about the Jmp instruction (my IL is still a bit lacking - still waiting for my copy of Inside Microsoft .NET IL Assembler), however as you stated I did omit the NewObj intentionally. Will update the rule to check for the Jmp instruction.

Do you know of any language that uses the Jmp instruction?

My AvoidComplicatedMethods rule really needs to be rewritten to take into account the cyclomatic complexity of a method rather than simply counting the number of method calls within it. There are a number of tools out there to measure this, so I might investigate this further.

David

DavidM.Kean at 2007-9-9 >