The rule “ImplementIDisposableCorrectly” should not be displayed in sealed classes as the Dispose(bool) method cannot be declared as protected or virtual.
Also, the help page for this rule has no text for this rule and when clicking the feedback button, it generates an e-mail with the subject ofInterfaceNamesHaveIPrefix
Steve
The only way I can FxCop to pick up a sealed class is by doing the following:
public sealed class Disposable : IDisposable { void IDisposable.Dispose() { } } |
However, this is a violation of the Dispose pattern, where Dispose should be public.
Michael
public sealed class Class1 : IDisposable { ~Class1( ) { Dispose ( false ) ; } public void Dispose() { Dispose( true ) ; } bool _disposed ; public void Dispose( bool disposing ) if ( disposing ) _disposed = true ; |
We should either modify the rule to flag this as a problem or fix the issue as originally described (stop firing this specific message on a sealed type). I'll talk to our in-house expert on this rule and get some guidance on which approach is best. In any case, we'll certainly take some kind of fix. Thanks again for taking the time to submit a repro,
Michael
